Enhance data viewer#317
Conversation
| f"#*{search_filter.name_part}*" | ||
| if search_filter is not None and search_filter.name_part is not None | ||
| else "#*" | ||
| ) |
There was a problem hiding this comment.
should probably change if design to if search_filter : and than in the nested ifs do the other ones, also would be nice to have comments describing the synax since f"#{search_filter.name}" is unclear
| "per_page": pages_filter.per_page, | ||
| "reverse": reverse, | ||
| } | ||
| if search_filter is not None: |
There was a problem hiding this comment.
instead of putting if for every parameter, we can iterate through parameters and assign if not value
There was a problem hiding this comment.
also, do we use timelinedb? do we use the added parameters?
| else: | ||
| return [] | ||
|
|
||
| if not isinstance(obj, (Mapping, Sequence)): |
There was a problem hiding this comment.
why is this change needed? it seems less conventional, am i missing something?
| ] | ||
|
|
||
| # Apply sorting if sort field is specified | ||
| if sort is not None: |
There was a problem hiding this comment.
i think there is a bug since it happens after pagination, it will sort the paginated file not everything
|
|
||
| AllowedSearchKeys = string.ascii_letters + string.digits + "-_*" | ||
|
|
||
|
|
There was a problem hiding this comment.
great mechanism! can you leave some comments explaining it for future developers?
|
I don't see new tests, am i missing them? |
2 participants
QUAL-1724 search by name and partial name
QUAL-1728 date filter
QUAL-1752 sort